dt-rust: Fix "Root" node detection #114
Conversation
The labels node should occur only at the root node in the Rust-converted devicetree. However, when translating the format of the yaml file to use explicit types, the rule for this node didn't end up in an array. It isn't clear why this doesn't generate an error, but making it an explicit array does fix the issue. Without this fix, the devicetree.rs that is generated has a duplicate copy of the labels module under every node. This fixes it to only occur at the top level. Fixes: #113 Signed-off-by: David Brown <[email protected]>
|
Might need a little helper if you using serde and you want an empty array to error out https://stackoverflow.com/questions/75016452/serde-how-to-error-out-when-deserializing-empty-arrays yaml is weird and issues like this might just be ignored 🤷 That's not unusual for yaml stuff. |
The thing is, I'm not sure an empty set of rules is exactly wrong. Well, maybe it is, as it would mean the actions should apply to every node. But, maybe there will be a future action where that makes sense. I'm not quite sure that the |
The labels node should occur only at the root node in the Rust-converted devicetree. However, when translating the format of the yaml file to use explicit types, the rule for this node didn't end up in an array. It isn't clear why this doesn't generate an error, but making it an explicit array does fix the issue.
Without this fix, the devicetree.rs that is generated has a duplicate copy of the labels module under every node. This fixes it to only occur at the top level.
Fixes: #113